Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle custom modifiers on parameter constraints #83850

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

steveharter
Copy link
Member

Fixes #83679.

Addresses an edge case where a custom modifier is used for a parameter constraint which caused a "modified" type to leak into the "unmodified" type universe which is not prepared for it (calling BaseType or Equals() for example throws on a modified type).

@steveharter steveharter added this to the 8.0.0 milestone Mar 23, 2023
@steveharter steveharter self-assigned this Mar 23, 2023
@ghost
Copy link

ghost commented Mar 23, 2023

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #83679.

Addresses an edge case where a custom modifier is used for a parameter constraint which caused a "modified" type to leak into the "unmodified" type universe which is not prepared for it (calling BaseType or Equals() for example throws on a modified type).

Author: steveharter
Assignees: steveharter
Labels:

area-System.Reflection

Milestone: 8.0.0

Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steveharter steveharter merged commit eb34be8 into dotnet:main Mar 24, 2023
@steveharter steveharter deleted the MlcModType branch March 24, 2023 16:26
@ghost ghost locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MetadataLoadContext: IsValueType: NotSupportedException: Modified types do not support this member
2 participants