-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lowering for As*() and dependent methods. #83861
Add lowering for As*() and dependent methods. #83861
Conversation
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue DetailsThis includes the following:
|
Not really, its on the backlog to add direct intrinsification and a general
This is hit when We accelerate only a subset of |
2d74c64
to
1c0f713
Compare
This includes the following: As(), AsByte(), AsDouble(), AsInt16(), AsInt32(), AsInt64(), AsNInt(), AsNUInt(), AsByte(), AsSingle(), AsUInt16(), AsUInt32(), AsUInt64(), AsVector(), AsVector512(), GetLower(), ToVector512()
Changes overall LGTM. Just a few code cleanup requests. |
Draft PR for that is here: #83982. I plan on finishing it after this PR goes in and will have it cover the new |
Failure is unrelated and being handled by #84012 |
CC. @dotnet/jit-contrib, @dotnet/avx512-contrib for secondary review and merge |
This includes the following Vector512 API methods:
As(), AsByte(), AsDouble(), AsInt16(), AsInt32(), AsInt64(), AsNInt(), AsNUInt(), AsByte(), AsSingle(), AsUInt16(), AsUInt32(), AsUInt64(), AsVector(), AsVector512(), GetLower(), ToVector512()
Open :
GetUpper()
is not lowered for Vector256 even though it's supported. Is this by choice?Vector256.AsVector()
orVector256.AsVector256()
has to be lowered which will happen only when target supports AVX2. Considering this, will we ever end up with a case whereVector<T>
size = 128 andVector256
gets lowered? I've not been able to manipulate .NET to hit this and this might be dead code. This extends forVector512.AsVector()
orVector512.AsVector512()
withxmm
too@dotnet/avx512-contrib