Set minimum language version allowed by config binding generator #83996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-extensions-configuration Issue DetailsFixes #83535. Enforces language version to be at least C#. The only feature we need to enforce a minimum version is The logic will probably be slightly refactored as part of #83534, but wanted to fix now & discuss as it seems like a policy decision.
|
This was referenced Mar 27, 2023
eerhardt
reviewed
Mar 28, 2023
...Microsoft.Extensions.Configuration.Binder/gen/ConfigurationBindingSourceGenerator.Helpers.cs
Outdated
Show resolved
Hide resolved
layomia
force-pushed
the
binder-gen-lang-version
branch
from
d479181
to
ba837d7
Compare
tarekgh
approved these changes
Mar 29, 2023
ghost
locked as resolved and limited conversation to collaborators
layomia
added
the
source-generator
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83535. Requires language version to be at least C# 11. This choice is rather arbitrary but follows the version required by the Regex generator (though it appears regex still generates partial code in some scenarios). The only feature we (currently) need to enforce a minimum version for is
nullable, which would be C# 8.0.The benefit of this change is that we'll emit a single diagnostic rather than generating
nullableannotating code which would cause multiple compiler diagnostics. The logic will probably be slightly refactored as part of #83534, but wanted to fix now & discuss as it seems like a policy decision.cc @eerhardt @ericstj