Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono] remove unneeded PKG_CONFIG_PATH for FreeBSD #84062

Merged
merged 2 commits into from
Apr 24, 2023
Merged

[mono] remove unneeded PKG_CONFIG_PATH for FreeBSD #84062

merged 2 commits into from
Apr 24, 2023

Conversation

Thefrank
Copy link
Contributor

@Thefrank Thefrank commented Mar 29, 2023

When cross building mono component, PKG_CONFIG_PATH was either not listed (x86_64) or contained a typo (ARM64).
As pointed out by @am11 neither variants use PKG_CONFIG_PATH here

When cross building, was either not listed (x86_64) or contained a typo (ARM64)
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Mar 29, 2023
@am11
Copy link
Member

am11 commented Mar 29, 2023

On FreeBSD, this is unused; we don't call pkg_check_modules(). So feel free to delete both lines.

Ideally, we should get rid of this manually maintained list from all platforms and switch to what coreclr and libs.native subsets are using: instead of include(findpkgconfig) and pkg_check_modules etc., use find_library.

@Thefrank Thefrank changed the title [mono] fix PKG_CONFIG_PATH for FreeBSD [mono] remove unneeded PKG_CONFIG_PATH for FreeBSD Mar 29, 2023
@Thefrank
Copy link
Contributor Author

@am11 I initially saw the typo path when generating an ARM64 build. As the build did not fail and it still found everything it needed I assumed it just fell back to using ROOTFS_DIR. The two important items ICU_INCLUDEDIR and ICU_LIBDIR are already set in the CMakeLists.txt for mono. The now-unneeded path fix was out of an abundance of caution.

@marek-safar marek-safar reopened this Apr 24, 2023
@marek-safar marek-safar merged commit 2d982ea into dotnet:main Apr 24, 2023
@Thefrank Thefrank deleted the freebsd-mono branch April 24, 2023 16:31
@ghost ghost locked as resolved and limited conversation to collaborators May 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Build-mono community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants