Introducing Time abstraction Part2 (down-level support) #84235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
needs-area-label
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
tarekgh
added
area-System.DateTime
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/area-system-datetime Issue DetailsThis change is adding the time abstraction to the down-levels.
|
|
@ericstj Could you please have a look at the newly introduced library and confirm I got the building and packaging, correct? CC @terrajobst |
stephentoub
reviewed
Apr 3, 2023
stephentoub
reviewed
Apr 3, 2023
...ibraries/Microsoft.Bcl.TimeProvider/src/System/Threading/Tasks/TimeProviderTaskExtensions.cs
Show resolved
Hide resolved
stephentoub
reviewed
Apr 3, 2023
...ibraries/Microsoft.Bcl.TimeProvider/src/System/Threading/Tasks/TimeProviderTaskExtensions.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Apr 3, 2023
...ibraries/Microsoft.Bcl.TimeProvider/src/System/Threading/Tasks/TimeProviderTaskExtensions.cs
Show resolved
Hide resolved
stephentoub
reviewed
Apr 3, 2023
...ibraries/Microsoft.Bcl.TimeProvider/src/System/Threading/Tasks/TimeProviderTaskExtensions.cs
Show resolved
Hide resolved
stephentoub
reviewed
Apr 3, 2023
...ibraries/Microsoft.Bcl.TimeProvider/src/System/Threading/Tasks/TimeProviderTaskExtensions.cs
Show resolved
Hide resolved
stephentoub
reviewed
Apr 3, 2023
...ibraries/Microsoft.Bcl.TimeProvider/src/System/Threading/Tasks/TimeProviderTaskExtensions.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Apr 3, 2023
...ibraries/Microsoft.Bcl.TimeProvider/src/System/Threading/Tasks/TimeProviderTaskExtensions.cs
Show resolved
Hide resolved
This was referenced Apr 3, 2023
ericstj
reviewed
Apr 3, 2023
src/libraries/Microsoft.Bcl.TimeProvider/src/Microsoft.Bcl.TimeProvider.csproj
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Bcl.TimeProvider/ref/Microsoft.Bcl.TimeProvider.Forwards.cs
Show resolved
Hide resolved
huoyaoyuan
reviewed
Apr 4, 2023
ericstj
approved these changes
Apr 4, 2023
...ibraries/Microsoft.Bcl.TimeProvider/src/System/Threading/Tasks/TimeProviderTaskExtensions.cs
Show resolved
Hide resolved
danmoseley
reviewed
Apr 5, 2023
...ibraries/Microsoft.Bcl.TimeProvider/src/System/Threading/Tasks/TimeProviderTaskExtensions.cs
Show resolved
Hide resolved
krwq
reviewed
Apr 5, 2023
...ibraries/Microsoft.Bcl.TimeProvider/src/System/Threading/Tasks/TimeProviderTaskExtensions.cs
Show resolved
Hide resolved
stephentoub
reviewed
Apr 6, 2023
stephentoub
reviewed
Apr 6, 2023
stephentoub
approved these changes
Apr 6, 2023
gewarren
reviewed
Apr 6, 2023
...ibraries/Microsoft.Bcl.TimeProvider/src/System/Threading/Tasks/TimeProviderTaskExtensions.cs
Outdated
Show resolved
Hide resolved
...ibraries/Microsoft.Bcl.TimeProvider/src/System/Threading/Tasks/TimeProviderTaskExtensions.cs
Outdated
Show resolved
Hide resolved
This was referenced Apr 7, 2023
ViktorHofer
reviewed
May 2, 2023
|
|
||
| <ItemGroup Condition="'$(IsPartialFacadeAssembly)' != 'true'"> | ||
| <PackageReference Include="Microsoft.Bcl.AsyncInterfaces" Version="$(MicrosoftBclAsyncInterfacesVersion)" /> | ||
| <PackageReference Include="System.ValueTuple" Version="$(SystemValueTupleVersion)" /> |
There was a problem hiding this comment.
netstandard2.0 shouldn't reference this library as it's already provided inbox.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is adding the time abstraction to the down-levels.
#83604
#36617