Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a tuned ConcurrentDictionary in the default caching implementation for the COM source generator #84335

Merged
merged 2 commits into from
Apr 7, 2023
Merged

Use a tuned ConcurrentDictionary in the default caching implementation for the COM source generator #84335

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
918b014
Use a ConcurrentDictionary to ensure we have at least a simple decent…
jkoritzinsky Apr 5, 2023
a8d969d
Change comment
jkoritzinsky Apr 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/libraries/System.Runtime.InteropServices/tests/Ancillary.Interop/DefaultCaching.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,17 @@
// The .NET Foundation licenses this file to you under the MIT license.

// Implementations of the COM strategy interfaces defined in Com.cs that we would want to ship (can be internal only if we don't want to allow users to provide their own implementations in v1).
using System.Collections.Concurrent;
using System.Collections.Generic;

namespace System.Runtime.InteropServices.Marshalling
{
internal sealed unsafe class DefaultCaching : IIUnknownCacheStrategy
{
// [TODO] Implement some smart/thread-safe caching
private readonly Dictionary<RuntimeTypeHandle, IIUnknownCacheStrategy.TableInfo> _cache = new();
// We limit the concurrency level to 1 writer as we believe this is the most common scenario and limiting the concurrency level
// significantly reduces memory overhead.
// We set the default capacity as a decent guess.
private readonly ConcurrentDictionary<RuntimeTypeHandle, IIUnknownCacheStrategy.TableInfo> _cache = new(concurrencyLevel: 1, capacity: 16);

IIUnknownCacheStrategy.TableInfo IIUnknownCacheStrategy.ConstructTableInfo(RuntimeTypeHandle handle, IIUnknownDerivedDetails details, void* ptr)
{
Expand Down