Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Roslyn dependency version in source-build #84366

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

jkoritzinsky
Copy link
Member

Now that Roslyn builds after dotnet/runtime in source-build, we don't want to use the live Roslyn version in our source-build build.

Unblocks dotnet/sdk#31571

Now that Roslyn builds after dotnet/runtime in source-build, we don't want to use the live Roslyn version in our source-build build.

Unblocks dotnet/sdk#31571
@jkoritzinsky jkoritzinsky added blocking Marks issues that we want to fast track in order to unblock other important work area-Infrastructure partner-impact This issue impacts a partner who needs to be kept updated labels Apr 5, 2023
@ghost ghost assigned jkoritzinsky Apr 5, 2023
@ghost
Copy link

ghost commented Apr 5, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Now that Roslyn builds after dotnet/runtime in source-build, we don't want to use the live Roslyn version in our source-build build.

Unblocks dotnet/sdk#31571

Author: jkoritzinsky
Assignees: -
Labels:

blocking, area-Infrastructure, partner-impact

Milestone: -

@jkoritzinsky
Copy link
Member Author

Test failures are unrelated. Merging in to unblock dotnet/sdk.

@jkoritzinsky jkoritzinsky merged commit cc01464 into main Apr 6, 2023
@jkoritzinsky jkoritzinsky deleted the source-build-version-fix branch April 6, 2023 06:23
@ghost ghost locked as resolved and limited conversation to collaborators May 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure blocking Marks issues that we want to fast track in order to unblock other important work partner-impact This issue impacts a partner who needs to be kept updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants