[release/6.0] Suppress clang-16 warnings (backport #81573) #84443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
needs-area-label
ghost
added
the
community-contribution
|
Backport #82461 at the same time? |
ayakael
force-pushed
the
backport/pr-81573-to-release/6.0
branch
from
8a26995
to
a6d9fbf
Compare
ayakael
force-pushed
the
backport/pr-81573-to-release/6.0
branch
from
a6d9fbf
to
db09bc2
Compare
ayakael
requested review from
vargaz,
lambdageek,
thaystg,
steveharter,
layomia and
eiriktsarpalis
as code owners
ayakael
changed the title
ayakael
changed the title
This was referenced Apr 7, 2023
|
cc @tommcdon (see #84444 (comment)) |
jeffhandley
added
area-Infrastructure
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsCustomer impactWithout this, .NET 6 fails to build on platforms that use clang-16 TestingTested on CI and manually on Alpine Linux edge. RiskLow. The flag that is set makes the compiler less strict.
|
hoyosjs
approved these changes
Apr 11, 2023
|
@mikem8361, @hoyosjs - if we want this change in the June Release, and it looks ready, please merge before May 15th (Code Complete). |
hoyosjs
approved these changes
May 4, 2023
|
Failures look related. |
hoyosjs
requested changes
May 5, 2023
src/native/corehost/apphost/static/singlefilehost_OSXexports.src
Outdated
Show resolved
Hide resolved
ghost
added
the
needs-author-action
ayakael
force-pushed
the
backport/pr-81573-to-release/6.0
branch
from
db09bc2
to
ac85caf
Compare
ghost
removed
the
needs-author-action
akoeplinger
approved these changes
May 5, 2023
|
Failures look unrelated to me now. |
This was referenced May 5, 2023
|
Today is code complete for the June Release. @hoyosjs @akoeplinger is this ready to merge? @hoyosjs you have a blocking review. |
hoyosjs
approved these changes
May 15, 2023
|
@carlossanlop this is ready 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #81573 and #82461
Customer impact
Without this, .NET 6 fails to build on platforms that use clang-16
Testing
Tested on CI and manually on Alpine Linux edge.
Risk
Low. The flag that is set makes the compiler less strict.
@am11 @omajid ptal.