Dogfood ComInterfaceGenerator in crossgen2 #84643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronRobinsonMSFT
approved these changes
Apr 13, 2023
agocke
approved these changes
Apr 13, 2023
jkoritzinsky
added
the
NO-MERGE
|
Marking this No Merge for now until we update it based on the fact that the APIs are now in the product and not in Ancillary.Interop. |
|
Is this blocked on another PR which adds new APIs so this change could use them? |
Yep. As soon as we update the repo to the shipping preview 4? (or is it 5?) SDK we can merge this. |
|
Looks like we're on preview 4 now, @jkoritzinsky are we good to merge? |
jkoritzinsky
approved these changes
May 22, 2023
src/coreclr/tools/aot/ILCompiler.Diagnostics/ILCompiler.Diagnostics.csproj
Outdated
Show resolved
Hide resolved
ghost
locked as resolved and limited conversation to collaborators
jtschuster
removed
the
NO-MERGE
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the manual ComWrappers implementation in crossgen2 with the ComInterfaceGenerator implementation.
ComInterfaceGenerator does not support chars yet, so they are replaced with ushort for the interface parameters, and manually cast to chars after the COM call.