Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Port perfmap environment variable change to 6.0 #84681

Merged
merged 2 commits into from
Apr 25, 2023

Conversation

davmason
Copy link
Member

@davmason davmason commented Apr 12, 2023

Ports #82142 to 6.0

Customer Impact

An internal partner team is running in to performance issues with generating both jit dumps and perfmap files. Currently we unconditionally do both and it all of the file IO can cause noticeable regressions. This change makes it so you can specify whether you want perfmaps, jit dumps, or both written out.

Testing

Partner team validation that it fixes their scenario.

Risk

Low, no known issues

@davmason davmason added this to the 6.0.x milestone Apr 12, 2023
@davmason davmason requested review from jeffschwMSFT and a team April 12, 2023 07:26
@davmason davmason self-assigned this Apr 12, 2023
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we will take for consideration in 6.0.x. please get a code review

@jeffschwMSFT jeffschwMSFT added the Servicing-consider Issue for next servicing release review label Apr 12, 2023
@leecow leecow added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Apr 13, 2023
@leecow leecow modified the milestones: 6.0.x, 6.0.17, 6.0.18 Apr 13, 2023
src/coreclr/vm/perfmap.cpp Outdated Show resolved Hide resolved
@carlossanlop
Copy link
Member

@davmason thanks for re-targeting to 6.0-staging. PR submitters now have permission to merge their own PRs once all the requirements are met:

  • CI is green or failures are investigated as unrelated.
  • Sign-off from area owner.
  • If product change, approved by Tactics and Servicing-approved label applied.
  • [NA] If test-only or infra-only change, Servicing-approved label applied.

Hit the squash&merge button whenever!

@davmason davmason merged commit eb5611b into dotnet:release/6.0-staging Apr 25, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Tracing-coreclr Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants