Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/6.0] Fix null being passed to g_path_get_dirname when probing in wasm #84740

Merged
merged 4 commits into from
Apr 12, 2023
Merged

[release/6.0] Fix null being passed to g_path_get_dirname when probing in wasm #84740

merged 4 commits into from
Apr 12, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 12, 2023 •
edited by lewing
Loading

Backport of #60445 to release/6.0-staging

fixes the failures in dotnet/aspnetcore#47652

/cc @lewing @kg

Customer Impact

Blazor can fail at startup due to code reordering

Testing

This code is included in 7.0 and works correctly there

Risk

Tiny change is already in 7 and 8
.

@ghost
Copy link

ghost commented Apr 12, 2023

Tagging subscribers to this area:
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #60445 to release/6.0-staging

/cc @lewing @kg

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-AssemblyLoader-mono
Milestone: -

@wtgodbe wtgodbe mentioned this pull request Apr 12, 2023
Merged
@lewing lewing added the Servicing-consider Issue for next servicing release review label Apr 12, 2023
@lewing lewing changed the base branch from release/6.0-staging to release/6.0 April 12, 2023 23:01
@lewing lewing changed the title [release/6.0-staging] Fix null being passed to g_path_get_dirname when probing in wasm [release/6.0] Fix null being passed to g_path_get_dirname when probing in wasm Apr 12, 2023
carlossanlop
carlossanlop reviewed Apr 12, 2023
View reviewed changes
Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retargeting from 6.0-staging to 6.0 accidentally brought the branding change we did in that branch (staging should always be one version ahead when the base branches are closed).

Reverting via code suggestions. The May Release is 6.0.17.

eng/Versions.props Outdated Show resolved Hide resolved
eng/Versions.props Outdated Show resolved Hide resolved
@carlossanlop carlossanlop added this to the 6.0.x milestone Apr 12, 2023
@lewing lewing added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Apr 12, 2023
@carlossanlop carlossanlop merged commit 51e6047 into release/6.0 Apr 12, 2023
@carlossanlop carlossanlop deleted the backport/pr-60445-to-release/6.0-staging branch April 12, 2023 23:47
This was referenced Apr 13, 2023
Open
Closed
Closed
@leecow leecow modified the milestones: 6.0.x, 6.0.17 Apr 13, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 13, 2023
@rbhanda rbhanda modified the milestones: 6.0.17, 6.0.18 Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlossanlop carlossanlop carlossanlop left review comments

@lewing lewing lewing approved these changes

@vargaz vargaz Awaiting requested review from vargaz

@lambdageek lambdageek Awaiting requested review from lambdageek lambdageek is a code owner

@thaystg thaystg Awaiting requested review from thaystg thaystg is a code owner

Assignees
No one assigned
Labels
area-AssemblyLoader-mono Servicing-approved Approved for servicing release
Projects
None yet
Milestone
6.0.18
Development

Successfully merging this pull request may close these issues.
5 participants
@lewing @carlossanlop @leecow @rbhanda @kg