[release/7.0-staging] Add status code and exception info to System.Net.Http events #84806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsBackport of #84036 to 7.0. Includes the following changes: -void RequestStop()
+void RequestStop(int statusCode)
-void ResponseHeadersStop()
+void ResponseHeadersStop(int statusCode)
-void RequestFailed();
+void RequestFailed(string exceptionMessage)Does not include the new Customer ImpactTODO TestingI added targeted CI tests that confirm new parameters are included in events. RiskTODO
|
|
All test failures are known according to Build Analysis. |
ericstj
reviewed
Apr 27, 2023
|
Approved by Tactics (Steve Carroll) on May 1st via email. Marking as servicing-approved. |
MihaZupan
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #84036 to 7.0.
Contributes to #83734.
Customer Impact
The networking stack is already instrumented with EventSource events that allow telemetry consumers to observe when requests are made and where they are spending time. Aside from a timestamp, these events often provide no or very few extra details.
On .NET Framework, a different EventSource provider exists that exposes information like the HTTP response status code. This provider does not exist on .NET Core+, and as a result, customers migrating their services from Framework are losing diagnostics information (e.g. XBox Live service).
This PR adds the response status code and exception message to existing events to cover that gap.
Testing
I added targeted CI tests that confirm new parameters are included in events.
Risk
Minimal.
Impacted code paths are all only reachable when telemetry is enabled.
With confirmation from @brianrob and @noahfalk, modifications to existing events in the manner done here are safe and non-breaking for existing telemetry consumers.