[mono][jit] Adding Vector128.Narrow,Widen as intrinsics on arm64. #84837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanyang-mono
approved these changes
Apr 14, 2023
tannergooding
approved these changes
Apr 14, 2023
vargaz
approved these changes
Apr 14, 2023
|
Failures are unrelated. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally this also adds
OP_XUNOPas a superoperation for SIMD operations that have one source and one dest register. Within that, the widening operations for use in JIT are defined. This is to facilitate the table-driven codegen in these cases. Also the preexisting solution would result in suboptimal codegen. Further standalone operations can be moved toOP_XUNOPin the future.Relevant arm64 codegen macros are ported to their general variant and fixed if neccessary.
Contributes to #80566.