Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0-staging] Tar: Add missing TarFile.CreateFromDirectoryAsync roundtrip tests #84856

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 14, 2023

Backport of #84303 to release/7.0-staging

/cc @carlossanlop

Customer Impact

Test-only change.

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

@ghost
Copy link

ghost commented Apr 14, 2023

Tagging subscribers to this area: @dotnet/area-system-formats-tar
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #84303 to release/7.0-staging

/cc @carlossanlop

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Formats.Tar

Milestone: -

@stephentoub
Copy link
Member

Curious why we're backporting a test-only addition?

@danmoseley
Copy link
Member

We've back ported new tests in the past, where there was a significant coverage hole.

@carlossanlop
Copy link
Member

We also backport tell-mode test-only changes. If we submit other Tar backports, I'd like to ensure we don't have coverage holes in the servicing branch.

@carlossanlop carlossanlop merged commit 7416d98 into release/7.0-staging May 3, 2023
@carlossanlop carlossanlop deleted the backport/pr-84303-to-release/7.0-staging branch May 3, 2023 18:49
@ghost ghost locked as resolved and limited conversation to collaborators Jun 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Formats.Tar Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants