JIT: enable one particular flow opt when we have PGO #84875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This particular optimization seems to be a good idea, so not sure why
the code was unwilling to do it if we had profile data.
This optimization removes a "branch around":
``
BlockA: jtrue (p) BlockC
BlockB: {empty} jmp BlockD
BlockC: ...
...
BlockD: ...
```
becomes
```
BlockA: jtrue (!p) BlockD
BlockC: ...
...
BlockD: ...
```
If later during code layout we decide we'd rather have
```
BlockA: jtrue (p) BlockC
BlockD: ...
...
BlockC: ...
```
we can still make that happen.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
assigned 
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue DetailsThis particular optimization seems to be a good idea, so not sure why the code was unwilling to do it if we had profile data. This optimization removes a "branch around": becomes If later during code layout we decide we'd rather have we can still make that happen.
|
|
@EgorBo PTAL Expect modest diffs in PGO collections. Fixes some cases where the method epilog was appearing after a bunch of throw blocks. |
EgorBo
approved these changes
Apr 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This particular optimization seems to be a good idea, so not sure why the code was unwilling to do it if we had profile data.
This optimization removes a "branch around":
becomes
If later during code layout we decide we'd rather have
we can still make that happen.