Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Move mono.mscordbi subset off the offical build #84939

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

steveisok
Copy link
Member

Backport of #81917

This isn't in use, so there's no need to build and ship it. Instead, this is being moved to the mono windows x64 public leg.

@steveisok
Copy link
Member Author

@carlossanlop this is a tell-mode change.

@steveisok steveisok requested a review from thaystg April 17, 2023 18:30
@steveisok
Copy link
Member Author

@carlossanlop @mmitche indicated he would like this in may servicing, so it needs promoted to release/6.0 as well.

@carlossanlop carlossanlop changed the base branch from release/6.0-staging to release/6.0 April 17, 2023 19:09
@carlossanlop
Copy link
Member

carlossanlop commented Apr 17, 2023

Retargeting included unexpected commits. I'll close this and request a fresh backport directly to release/6.0.

Edit: That didn't work, the bot found conflicts. Reopened this and force-pushed.

Backport of dotnet#81917

This isn't in use, so there's no need to build and ship it. Instead, this is being moved to the mono windows x64 public leg.
@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Apr 17, 2023
@carlossanlop
Copy link
Member

One of the wasm failures has this message:

/datadisks/disk1/work/AE18094F/p/build/WasmApp.targets(209,5): warning : Could not find $(AssemblyName)=.dll in the assemblies to be bundled. [/datadisks/disk1/work/AE18094F/p/wasm-test-runner/WasmTestRunner.proj]
      console.info: Arguments: --run,DllImportSearchPathsTest.dll
      console.debug: MONO_WASM: Initializing mono runtime
      console.debug: MONO_WASM: ICU data archive(s) loaded, disabling invariant mode
      console.debug: mono_wasm_runtime_ready fe00e07a-5519-4dfe-b35a-f867dbaf2e28
      console.info: Initializing.....
      Test Failure: System.ArgumentNullException: Value cannot be null. (Parameter 'path1')
         at System.IO.Path.Combine(String path1, String path2)
         at DllImportSearchPathsTest.get_Subdirectory()
         at DllImportSearchPathsTest.AssemblyDirectory_Found()
         at DllImportSearchPathsTest.Main(String[] args)

I think it's #84724 but the top error message Could not find $(AssemblyName)=.dll in the assemblies to be bundled. is weird, I have not seen it before. @elinor-fung @lewing can you confirm it's the exact same issue?

If it's different, let me know so I open a new issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants