Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LoongArch64] amend the crossgen2/r2rdump for LA64. #85038

Merged
merged 3 commits into from
May 17, 2023
Merged

[LoongArch64] amend the crossgen2/r2rdump for LA64. #85038

merged 3 commits into from
May 17, 2023

Conversation

shushanhf
Copy link
Contributor

This PR is part of the issue #69705 to amend the LA's port.

Amend the crossgen2/r2rdump for LA64.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Apr 19, 2023
@build-analysis build-analysis bot mentioned this pull request Apr 19, 2023
Closed
@am11 am11 mentioned this pull request Apr 20, 2023
Closed
@shushanhf
Copy link
Contributor Author

Hi, @jkotas
Could you please review this PR?
Thanks

@jkotas jkotas requested review from cshung and trylek April 23, 2023 14:43
@jkotas
Copy link
Member

jkotas commented Apr 23, 2023

Could you please review this PR?

This should be reviewed by @cshung and @trylek

trylek
trylek approved these changes Apr 23, 2023
View reviewed changes
Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't pretend to be a loongarch calling convention expert but overall the changes look reasonable to me.

@shushanhf
Copy link
Contributor Author

shushanhf commented Apr 24, 2023 •
edited
Loading

I don't pretend to be a loongarch calling convention expert but overall the changes look reasonable to me.

Thanks.
I had tested these by crossgen2 on LA64's runtime6.0.

@am11 am11 mentioned this pull request Apr 24, 2023
Merged
@cshung cshung mentioned this pull request May 5, 2023
Merged
9 tasks
@build-analysis build-analysis bot mentioned this pull request May 17, 2023
Open
@jkotas jkotas merged commit af1171b into dotnet:main May 17, 2023
@shushanhf shushanhf deleted the amend_crossgen2 branch May 18, 2023 00:46
@ghost ghost locked as resolved and limited conversation to collaborators Jun 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eduardo-vp eduardo-vp eduardo-vp left review comments

@trylek trylek trylek approved these changes

@jkotas jkotas jkotas left review comments

@am11 am11 am11 left review comments

@christophwille christophwille christophwille left review comments

@cshung cshung Awaiting requested review from cshung

Assignees
No one assigned
Labels
arch-loongarch64 area-crossgen2-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@shushanhf @jkotas @christophwille @cshung @am11 @trylek @eduardo-vp