[release/6.0-staging][wasm][debugger] Remove error message when browser is closed #85062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @thaystg Issue DetailsDescriptionOnly skipping printing the error if we have an exception of type: WebSocketException Customer ImpactWhen the browser is closed an exception is printed to console. RegressionYes, when we backported the communication from .net7 to .net6 to fix other issue, we regressed this and started printing the disconnection exception again. TestingManually tested RiskLow risk. Only not printing the error. Package authoring signed off?N/A IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
thaystg
changed the title
radical
approved these changes
Apr 19, 2023
This was referenced Apr 19, 2023
|
@carlossanlop failures here are known |
lewing
approved these changes
Apr 20, 2023
rbhanda
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Only skipping printing the error if we have an exception of type: WebSocketException
Customer Impact
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1784268
When the browser is closed an exception is printed to console.
Regression
Yes, when we backported the communication from .net7 to .net6 to fix other issue, we regressed this and started printing the disconnection exception again.
Testing
Manually tested
Risk
Low risk. Only not printing the error.
Package authoring signed off?
N/A
IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.