Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to P/Invokes and DllImport from resource strings in ComInterfaceGenerator #85178

Merged
merged 2 commits into from
May 20, 2023

Conversation

jkoritzinsky
Copy link
Member

Our diagnostic messages in ComInterfaceGenerator should reference GeneratedComInterface/ComImport, not LibraryImport/DllImport.

@ghost
Copy link

ghost commented Apr 21, 2023

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

Our diagnostic messages in ComInterfaceGenerator should reference GeneratedComInterface/ComImport, not LibraryImport/DllImport.

Author: jkoritzinsky
Assignees: jkoritzinsky
Labels:

area-System.Runtime.InteropServices

Milestone: -

@jkoritzinsky jkoritzinsky merged commit 0939905 into dotnet:main May 20, 2023
@jkoritzinsky jkoritzinsky deleted the resource-string-cleanup branch May 20, 2023 06:43
@ghost ghost locked as resolved and limited conversation to collaborators Jun 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Runtime.InteropServices source-generator Indicates an issue with a source generator feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants