-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JIT: Introduce GT_JTEST and clean up GT_JCMP flags #85242
Conversation
jakobbotsch
commented
Apr 24, 2023
- Introduce GT_JTEST to replace GTF_JCMP_TEST
- Stop encoding JCMP conditions in GenTreeFlags by switching GT_JCMP to a GenTreeOpCC node. This removes GTF_JCMP_EQ and the LoongArch64/RISC-V specific mechanism to communicate condition codes to the backend via gtFlags.
* Introduce GT_JTEST to replace GTF_JCMP_TEST * Stop encoding JCMP conditions in GenTreeFlags by switching GT_JCMP to a GenTreeOpCC node. This removes GTF_JCMP_EQ and the LoongArch64/RISC-V specific mechanism to communicate condition codes to the backend via gtFlags.
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue Details
|
cc @shushanhf @clamp03. This is an alternative to #85217 that stops using Also, unrelated to this PR, but I had to apply several patches to get the RISC-V/LoongArch cross-jits to build: https://gist.github.com/jakobbotsch/a11071cec499ef260fbe1b5c85c1b32f |
Thansk.
I will add LA64's image for CI. dotnet/dotnet-buildtools-prereqs-docker#856 |
cc @dotnet/jit-contrib PTAL @TIHan -- related to what we have discussed a couple of times. No diffs. @clamp03 @shushanhf If you can test the LA/RISC-V changes it would be great. |
OK,I will test it later. |
I just tested some cases. I think this is ok. |
@jakobbotsch |
Thank you. I will check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked on RISC-V. It works well. Thank you.