Avoid calling Encoding.GetBytes when Vector128 is not hardware accelerated #85267
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A performance regression (dotnet/perf-autofiling-issues#15719 ) was detected when running with mono interpreter which might be related to #73336
This is a simple follow up which disables the fast path for encoding introduced in #73336 if SIMD hardware acceleration is not availible.
Some measurements on Zen 3 hardware (with SSE disabled) shows that
This version just disables the new path when hardware acceleration is missing, but I have prepared an alternative version which is smarter in 64bit mode when simd is missing in case you prefer that version instead.
I assumed the simples possible code was preferred since I believe hardware acceleration is available on the majority of hardware.