Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0-staging][native-library] If a dllimport is specified with an absolute path, look for it first #85271

Conversation

lambdageek
Copy link
Member

@lambdageek lambdageek commented Apr 24, 2023

Backport of #85255 to release/7.0-staging

/cc @lambdageek

Customer Impact

Fixes application crashes on MacCatalyst in apps that use system frameworks such as SceneKit.

Testing

Manual testing

Risk

Low. This reverts to the behavior before 5a1baeb for DllImports with an absolute path.

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.


The unmanaged native library probing documentation says to try absolute paths without variations

https://learn.microsoft.com/en-us/dotnet/core/dependency-loading/default-probing#unmanaged-native-library-probing

Manual backport of #85255 to net6

…ook for it first

The unmanaged native library probing documentation says to try
absolute paths without variations

https://learn.microsoft.com/en-us/dotnet/core/dependency-loading/default-probing#unmanaged-native-library-probing

Manual backport of  dotnet#85255 to net6
@ghost ghost assigned lambdageek Apr 24, 2023
@lambdageek lambdageek added Servicing-consider Issue for next servicing release review and removed area-AssemblyLoader-mono labels Apr 24, 2023
@lambdageek lambdageek added this to the 6.0.x milestone Apr 24, 2023
@ghost
Copy link

ghost commented Apr 24, 2023

Tagging subscribers to this area:
See info in area-owners.md if you want to be subscribed.

Issue Details

The unmanaged native library probing documentation says to try absolute paths without variations

https://learn.microsoft.com/en-us/dotnet/core/dependency-loading/default-probing#unmanaged-native-library-probing

Manual backport of #85255 to net6

Author: lambdageek
Assignees: lambdageek
Labels:

area-AssemblyLoader-mono

Milestone: -

@ghost
Copy link

ghost commented Apr 24, 2023

Tagging subscribers to this area:
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #85255 to release/7.0-staging

/cc @lambdageek

Customer Impact

Fixes application crashes on MacCatalyst.

Testing

Manual testing

Risk

Low. This reverts to the behavior before 5a1baeb for DllImports with an absolute path.

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.


The unmanaged native library probing documentation says to try absolute paths without variations

https://learn.microsoft.com/en-us/dotnet/core/dependency-loading/default-probing#unmanaged-native-library-probing

Manual backport of #85255 to net6

Author: lambdageek
Assignees: lambdageek
Labels:

Servicing-consider, area-AssemblyLoader-mono

Milestone: 6.0.x

@lambdageek
Copy link
Member Author

@vargaz @thaystg can I get a review

@lambdageek lambdageek merged commit e8876e4 into dotnet:release/6.0-staging Apr 26, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants