Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Add more PackedSimd methods, logic ops #85303

Merged
merged 2 commits into from
Apr 25, 2023
Merged

[wasm] Add more PackedSimd methods, logic ops #85303

merged 2 commits into from
Apr 25, 2023

Conversation

radekdoulik
Copy link
Member

No description provided.

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost assigned radekdoulik Apr 25, 2023
@radekdoulik radekdoulik requested a review from lewing April 25, 2023 09:47
@ghost
Copy link

ghost commented Apr 25, 2023

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: radekdoulik
Assignees: -
Labels:

area-System.Runtime.Intrinsics, new-api-needs-documentation
Milestone: -

This was referenced Apr 25, 2023
Closed
Closed
@radekdoulik
Copy link
Member Author

the CI failures are unrelated

@radekdoulik radekdoulik merged commit a6f20f2 into dotnet:main Apr 25, 2023
@akoeplinger
Copy link
Member

akoeplinger commented Apr 25, 2023 •
edited
Loading

@radekdoulik I think the ios-arm64 and tvos-arm64 ones might be related, at least we started seeing #85345 that we didn't see in last night's build.

akoeplinger
akoeplinger reviewed Apr 25, 2023
View reviewed changes
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Wasm/PackedSimd.cs
/// <summary>
/// v128.or
/// </summary>
public static Vector128<sbyte> Or(Vector128<sbyte> left, Vector128<sbyte> right) => Or(left, right);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these not missing [Intrinsic] ?

@akoeplinger akoeplinger mentioned this pull request Apr 25, 2023
Closed
This was referenced Apr 26, 2023
Open
Closed
@radekdoulik radekdoulik mentioned this pull request Apr 26, 2023
Merged
@radekdoulik
Copy link
Member Author

@radekdoulik I think the ios-arm64 and tvos-arm64 ones might be related, at least we started seeing #85345 that we didn't see in last night's build.

I think I removed accidentally one of the ops on arm64. The above mentioned PR should fix it.

@ghost ghost locked as resolved and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@akoeplinger akoeplinger akoeplinger left review comments

@vargaz vargaz vargaz approved these changes

@lambdageek lambdageek Awaiting requested review from lambdageek

@SamMonoRT SamMonoRT Awaiting requested review from SamMonoRT

@lewing lewing Awaiting requested review from lewing

Assignees

@radekdoulik radekdoulik

Labels
area-System.Runtime.Intrinsics new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@radekdoulik @akoeplinger @vargaz