[browser] Use Wasm SDK in browser template #85311
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
maraf
commented
Apr 25, 2023
•
maraf
commented
- Update browser template to use Wasm SDK
- Use Blazor DevServer to run browser template
- Rename mono-config to blazor.boot.json to unify location where to load config from
- Update Wasm.Build.Tests
|
Tagging subscribers to 'arch-wasm': @lewing Issue Details
|
maraf
changed the title
maraf
commented
Apr 25, 2023
| <AllowUnsafeBlocks>true</AllowUnsafeBlocks> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <WasmExtraFilesToDeploy Include="index.html" /> | ||
| <WasmExtraFilesToDeploy Include="main.js" /> | ||
| <PackageReference Include="Microsoft.AspNetCore.Components.WebAssembly.DevServer" Version="8.0.0-preview.4.23177.9" PrivateAssets="all" /> |
There was a problem hiding this comment.
I can't think of a good one at the moment :/
There was a problem hiding this comment.
aspnetcore uses .csproj.in template files and fills them in with a generated version. https://github.com/dotnet/aspnetcore/blob/015ceab6aeec700fbfb71cdfe9ff8fb51831d555/src/ProjectTemplates/Web.ProjectTemplates/Microsoft.DotNet.Web.ProjectTemplates.csproj
There was a problem hiding this comment.
Does our versions always match?
maraf
commented
Apr 25, 2023
|
|
||
| const { setModuleImports, getAssemblyExports, getConfig } = await dotnet | ||
| .withStartupOptions({}) |
There was a problem hiding this comment.
This is temporal and shouldn't be in template
This was referenced Apr 25, 2023
This was referenced Apr 30, 2023
…thMonoConfig" This reverts commit 0521238.
|
Closed in favor of #85498 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.