Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser] Load appsettings to VFS #85520

Merged
merged 12 commits into from
May 16, 2023
Merged

[browser] Load appsettings to VFS #85520

merged 12 commits into from
May 16, 2023

Conversation

maraf
Copy link
Member

@maraf maraf commented Apr 28, 2023 •
edited
Loading

  • Take responsibility of loading correct appsettings
  • Put loaded files into VFS, so they can be accessed like in any other .NET application

Contributes to #70762

@maraf maraf added this to the 8.0.0 milestone Apr 28, 2023
@maraf maraf self-assigned this Apr 28, 2023
@ghost
Copy link

ghost commented Apr 28, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Take responsibility of loading correct appSettings
  • Put loaded files into VFS, so they can be accessed like in any other .NET application

Contributes to #70762

Author: maraf
Assignees: maraf
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone: 8.0.0

@build-analysis build-analysis bot mentioned this pull request Apr 28, 2023
Closed
@maraf maraf marked this pull request as ready for review May 3, 2023 16:02
@maraf maraf changed the title [browser] Load appSettings to VFS [browser] Load appsettings to VFS May 3, 2023
@pavelsavara
Copy link
Member

As I'm working on the loader, this has large conflict area with my work. I would appreciate if this could wait.
Also we have existing way how we install assets into VFS, could that be used ?
Finally, I wonder if this should be new asset type, because it could be possibly loaded later than DLLs ?

@maraf
Copy link
Member Author

maraf commented May 3, 2023

As I'm working on the loader, this has large conflict area with my work. I would appreciate if this could wait.

Ook

Also we have existing way how we install assets into VFS, could that be used ?

Good idea! I'll transform configs into mono-config VFS entries.

@maraf maraf marked this pull request as draft May 3, 2023 18:21
@maraf
Copy link
Member Author

maraf commented May 4, 2023

Waiting for loader PR to land

@build-analysis build-analysis bot mentioned this pull request May 4, 2023
Closed
@lewing lewing closed this May 11, 2023
@lewing lewing reopened this May 11, 2023
@runfoapp runfoapp bot mentioned this pull request May 11, 2023
Closed
@maraf maraf marked this pull request as ready for review May 12, 2023 08:16
@maraf maraf requested a review from radical as a code owner May 15, 2023 12:07
@maraf maraf merged commit 522c281 into dotnet:main May 16, 2023
@maraf maraf deleted the WasmAppSettings branch May 16, 2023 07:34
@maraf maraf mentioned this pull request May 19, 2023
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Jun 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pavelsavara pavelsavara pavelsavara approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@kg kg Awaiting requested review from kg

@radical radical Awaiting requested review from radical

Assignees

@maraf maraf

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@maraf @pavelsavara @lewing