Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change severity for SYSLIB1006 to Info instead of warning #85581

Merged
merged 1 commit into from
May 1, 2023

Conversation

ShreyasJejurkar
Copy link
Contributor

@ShreyasJejurkar ShreyasJejurkar commented May 1, 2023

Hopefully fixes #72263

EventId can be the same, let's not warn if it's not the same.

Documentation link -> https://learn.microsoft.com/en-us/aspnet/core/fundamentals/logging/?view=aspnetcore-7.0#log-event-id

image

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label May 1, 2023
@ghost
Copy link

ghost commented May 1, 2023

Tagging subscribers to this area: @dotnet/area-extensions-logging
See info in area-owners.md if you want to be subscribed.

Issue Details

Hopefully fixes #72263

EventId can be the same, it should not be different.

Documentation link -> https://learn.microsoft.com/en-us/aspnet/core/fundamentals/logging/?view=aspnetcore-7.0#log-event-id

image

Author: ShreyasJejurkar
Assignees: -
Labels:

area-Extensions-Logging

Milestone: -

@tarekgh tarekgh closed this May 1, 2023
@tarekgh tarekgh reopened this May 1, 2023
@tarekgh tarekgh merged commit ad3e4b7 into dotnet:main May 1, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Extensions-Logging community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive for SYSLIB1006 when user haven't specified EventID
2 participants