Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move assignment rationalization to before the late helper expansion phases #85585

Merged
merged 13 commits into from
May 2, 2023

Conversation

SingleAccretion
Copy link
Contributor

@SingleAccretion SingleAccretion commented May 1, 2023

And adapt more common code to work with store nodes, notably, block morphing and costing. The latter had to be refactored quite substantially to avoid regressing TP.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label May 1, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 1, 2023
@ghost
Copy link

ghost commented May 1, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

And adapt more morph code to work with store nodes, notably, block morphing.

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution

Milestone: -

@SingleAccretion
Copy link
Contributor Author

Diffs - no code diffs as expected, TP regression is an artifact of how the overall work from #85494 is being sliced.

@dotnet/jit-contrib

@SingleAccretion SingleAccretion marked this pull request as ready for review May 1, 2023 14:14
@jakobbotsch
Copy link
Member

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress, Fuzzlyn

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@SingleAccretion
Copy link
Contributor Author

Some failures and timeouts in libraries stress, but all look present in an earlier run as well.

Copy link
Member

@jakobbotsch jakobbotsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I'll also run Fuzzlyn just to be safe.

@jakobbotsch
Copy link
Member

Nevermind, I ran Fuzzlyn with the stress jobs, so looks like we are good to go :-)

@jakobbotsch jakobbotsch merged commit 53b4cd0 into dotnet:main May 2, 2023
@SingleAccretion SingleAccretion deleted the Op-Req-Asg-Before-Opts branch May 4, 2023 00:46
@ghost ghost locked as resolved and limited conversation to collaborators Jun 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants