Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Wasm.Build.Tests - Override KnownWebAssemblySdkPack to 8.0.0-dev #85815

Merged
merged 4 commits into from
May 9, 2023

Conversation

maraf
Copy link
Member

@maraf maraf commented May 5, 2023

Override version of KnownWebAssemblySdkPack in Microsoft.NETCoreSdk.BundledVersions.props to point to local built package

@maraf maraf added arch-wasm WebAssembly architecture area-Build-mono labels May 5, 2023
@maraf maraf added this to the 8.0.0 milestone May 5, 2023
@maraf maraf self-assigned this May 5, 2023
@ghost
Copy link

ghost commented May 5, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: maraf
Assignees: maraf
Labels:

arch-wasm, area-Build-mono

Milestone: 8.0.0

@maraf
Copy link
Member Author

maraf commented May 5, 2023

@radical It seems that it uses for some reason a global nuget cache. Am I doing something wrong?

image

@maraf maraf marked this pull request as ready for review May 5, 2023 15:46
@maraf maraf requested a review from radical as a code owner May 5, 2023 15:46
@maraf maraf requested a review from lewing May 5, 2023 15:46
@radical
Copy link
Member

radical commented May 5, 2023

@radical It seems that it uses for some reason a global nuget cache. Am I doing something wrong?

image

How did you get this? I tried it locally, and even if I have 8.0.0-dev in my global cache, the tests always correctly pick up from the test-local fresh cache.

@maraf
Copy link
Member Author

maraf commented May 6, 2023

How did you get this?

I built the dotnet-latest using the target from WBT to build it and than
I'm using dotnet-latest/dotnet.exe to create project and etc. I'll try from scratch next week and dig in.

@radical
Copy link
Member

radical commented May 6, 2023

Using dotnet from there won't change where the nuget cache is used from. That special setup is for the tests. You can override it manually or use a custom nuget.config . You can find one with the built test projects.

@maraf
Copy link
Member Author

maraf commented May 9, 2023

Ook, I knew about nuget feed configuration, but I was missing $env:NUGET_PACKAGES. Thanks!

@radical This is ready for review than.

Copy link
Member

@pavelsavara pavelsavara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@radical feel free to further improve this in subsequent PRs
We need to unblock #85730

@maraf maraf merged commit a442971 into dotnet:main May 9, 2023
@maraf maraf deleted the WasmSdkWbtOverridePackVersion branch May 9, 2023 09:55
@ghost ghost locked as resolved and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants