-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mono][aot] Deduplicate runtime invoke wrappers on iOS #85908
[mono][aot] Deduplicate runtime invoke wrappers on iOS #85908
Conversation
/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-extra-platforms |
Azure Pipelines successfully started running 3 pipeline(s). |
The
/cc: @steveisok @SamMonoRT @vargaz |
/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-extra-platforms |
Azure Pipelines successfully started running 3 pipeline(s). |
Are the random failures happening only as part of your PR, or have we seen those random failures outside your PR? If only in PR, I say try to add more logging and see if we can pinpoint any relevant fixes. |
These failures are also present in other pipeline runs, always reporting the TCP failure. In this PR, the following pipelines fail, which could indicate that the issue could be with the tests scheduling or networking:
However, upon retrying the runs, the distribution of failures remains unchanged, which leads to a suspicion that the issue might be related. There are no other error logs indicating that the runtime can't find the runtime invoke wrappers. |
Test retries indicate that the failures occur randomly. Based on the test logs, it is observed that the failures do not follow any pattern and can happen randomly during the test suite execution, without being tied to any particular test. |
@akoeplinger @steveisok I think you could provide valuable feedback as you have encountered the TCP failure in the past. |
I've merged this PR. If we encounter more frequent failures following the merge, I will revert the change. /cc: @akoeplinger @steveisok |
Agreed, I think this change does have an impact on CI and needs reverted. |
This reverts commit 4258272.
This PR deduplicates runtime invoke wrappers on iOS, which aligns WASM and iOS implementations. Approximately 30 runtime invoke wrappers have been deduplicated, resulting in minimal size savings. According to the HelloiOS measurements, the reduction amounts to about 2kb or 0.01%, which could be within the margin of statistical error.
Such change had an issue with the CI in #84304, even though the tests passed locally.
Fixes #83973