Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PreserveSig support to ComInterfaceGenerator #85941

Merged
merged 1 commit into from
May 10, 2023
Merged

Add PreserveSig support to ComInterfaceGenerator #85941

merged 1 commit into from
May 10, 2023

Conversation

jkoritzinsky
Copy link
Member

Add support for PreserveSig and some unit tests that validate the shape of the emitted function pointer signature.

Fixes #85816

@jkoritzinsky
Add PreserveSig support to ComInterfaceGenerator
eae8112 
Add support for PreserveSig and some unit tests that validate the shape of the emitted function pointer signature.
@jkoritzinsky jkoritzinsky added area-System.Runtime.InteropServices source-generator Indicates an issue with a source generator feature labels May 8, 2023
@jkoritzinsky jkoritzinsky added this to the 8.0.0 milestone May 8, 2023
@ghost ghost assigned jkoritzinsky May 8, 2023
@ghost
Copy link

ghost commented May 8, 2023

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

Add support for PreserveSig and some unit tests that validate the shape of the emitted function pointer signature.

Fixes #85816

Author: jkoritzinsky
Assignees: -
Labels:

area-System.Runtime.InteropServices, source-generator
Milestone: 8.0.0

@jkoritzinsky jkoritzinsky mentioned this pull request May 8, 2023
Closed
@build-analysis build-analysis bot mentioned this pull request May 9, 2023
Closed
AaronRobinsonMSFT
AaronRobinsonMSFT approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The product changes should be viewed excluding whitespace, they are trivial.

elinor-fung
elinor-fung approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@elinor-fung elinor-fung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe in a separate change, but I think it'd be good to add something to the integration tests too.

...ystem.Runtime.InteropServices/tests/ComInterfaceGenerator.Unit.Tests/TargetSignatureTests.cs Show resolved Hide resolved
jtschuster
jtschuster approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@jtschuster jtschuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkoritzinsky jkoritzinsky merged commit 40a1cea into dotnet:main May 10, 2023
@jkoritzinsky jkoritzinsky deleted the preservesig-com branch May 10, 2023 18:09
@ghost ghost locked as resolved and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elinor-fung elinor-fung elinor-fung approved these changes

@jtschuster jtschuster jtschuster approved these changes

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT approved these changes

Assignees

@jkoritzinsky jkoritzinsky

Labels
area-System.Runtime.InteropServices source-generator Indicates an issue with a source generator feature
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

[ComInterfaceGenerator] Support PreserveSig on methods
4 participants
@jkoritzinsky @AaronRobinsonMSFT @jtschuster @elinor-fung