Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert urllib reorder #86000

Merged
merged 1 commit into from
May 9, 2023
Merged

Revert urllib reorder #86000

merged 1 commit into from
May 9, 2023

Conversation

LoopedBard3
Copy link
Member

The performance runs are back to failing due to ssl errors in most cases after: "Previous changes fixed some runs, but some are still broken due to reinstall installing a broken urllib version. (#85935)". This reverts that commit, although some runs may still be broken.

…ue to reinstall installing a broken urllib version. (dotnet#85935)"

This reverts commit 4ea93a6.
@ghost
Copy link

ghost commented May 9, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

The performance runs are back to failing due to ssl errors in most cases after: "Previous changes fixed some runs, but some are still broken due to reinstall installing a broken urllib version. (#85935)". This reverts that commit, although some runs may still be broken.

Author: LoopedBard3
Assignees: LoopedBard3
Labels:

area-Infrastructure

Milestone: -

@LoopedBard3
Copy link
Member Author

Important and only impacts Performance pipelines, merging.

@LoopedBard3 LoopedBard3 merged commit b6f6dd0 into dotnet:main May 9, 2023
@LoopedBard3 LoopedBard3 deleted the PerfRever85935 branch May 9, 2023 17:43
LoopedBard3 added a commit to LoopedBard3/runtime that referenced this pull request Jun 7, 2023
…ue to reinstall installing a broken urllib version. (dotnet#85935)" (dotnet#86000)

This reverts commit 4ea93a6 due to the commit seemingly causes major failure in the pipelines.
@ghost ghost locked as resolved and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants