Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PERF] Add arm64 dynamic pgo runs #86014

Merged
merged 8 commits into from
May 10, 2023

Conversation

LoopedBard3
Copy link
Member

@LoopedBard3 LoopedBard3 commented May 9, 2023

This adds dynamic PGO arm64 runs to our regularly scheduled runs. It seems that everything should be properly configured just by setting the pgoRunType to DynamicPgo which then sets COMPlus_TieredPGO=1.

This is essentially a PR to get Linux PGO scenarios on par with the Windows ones from: 6c31866

@ghost
Copy link

ghost commented May 9, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

This adds dynamic PGO arm64 runs to our regularly scheduled runs. It seems that everything should be properly configured just by setting the pgoRunType to DynamicPgo which then sets COMPlus_TieredPGO=1.

Author: LoopedBard3
Assignees: LoopedBard3
Labels:

area-Infrastructure

Milestone: -

@LoopedBard3 LoopedBard3 marked this pull request as draft May 9, 2023 19:33
@LoopedBard3
Copy link
Member Author

Successful test (at least one of the logs for windows run succeeded) for arm64 dynamicPGO: https://dev.azure.com/dnceng/internal/_build/results?buildId=2177008&view=results

@LoopedBard3
Copy link
Member Author

@LoopedBard3 LoopedBard3 marked this pull request as ready for review May 10, 2023 19:04
@LoopedBard3 LoopedBard3 requested a review from radical as a code owner May 10, 2023 19:04
@LoopedBard3
Copy link
Member Author

All Perf pipeline tests resulted in passing data where this PR affected with the proper COMPLUS_Tiered...=1 being set. This also only impacts Perf Infrastructure so runtime pipeline failures are unrelated. Merging.

@LoopedBard3 LoopedBard3 merged commit 11e22ce into dotnet:main May 10, 2023
@LoopedBard3 LoopedBard3 deleted the PerfAddArmDynamicPGO branch May 10, 2023 21:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants