Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for RUC warnings on override methods #86015

Merged
merged 4 commits into from
May 12, 2023
Merged

Add tests for RUC warnings on override methods #86015

merged 4 commits into from
May 12, 2023

Conversation

vitek-karas
Copy link
Member

@vitek-karas vitek-karas commented May 9, 2023 •
edited
Loading

These are tests for bug #86008.

I also restructured the test file into nested classes some more as it's easier to navigate this way.

Also adds a test for #86032.

@vitek-karas vitek-karas added test-enhancement Improvements of test source code area-Tools-ILLink .NET linker development as well as trimming analyzers labels May 9, 2023
@vitek-karas vitek-karas added this to the 8.0.0 milestone May 9, 2023
@vitek-karas vitek-karas requested a review from sbomer May 9, 2023 20:31
@vitek-karas vitek-karas requested a review from marek-safar as a code owner May 9, 2023 20:31
@vitek-karas vitek-karas self-assigned this May 9, 2023
@ghost ghost added the linkable-framework Issues associated with delivering a linker friendly framework label May 9, 2023
@ghost
Copy link

ghost commented May 9, 2023

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

Issue Details

These are tests for bug #86008.

I also restructured the test file into nested classes some more as it's easier to navigate this way.

Author: vitek-karas
Assignees: vitek-karas
Labels:

test-enhancement, area-Tools-ILLink
Milestone: 8.0.0

@ghost
Copy link

ghost commented May 9, 2023

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr, @marek-safar
See info in area-owners.md if you want to be subscribed.

Issue Details

These are tests for bug #86008.

I also restructured the test file into nested classes some more as it's easier to navigate this way.

Author: vitek-karas
Assignees: vitek-karas
Labels:

test-enhancement, linkable-framework, area-Tools-ILLink
Milestone: 8.0.0

This was referenced May 10, 2023
Closed
Closed
@vitek-karas
Copy link
Member Author

All CI failures are unrelated

@build-analysis build-analysis bot mentioned this pull request May 10, 2023
Closed
sbomer
sbomer approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vitek-karas vitek-karas merged commit 5fabb48 into dotnet:main May 12, 2023
@vitek-karas vitek-karas deleted the TestWarnDAMOverride branch May 12, 2023 20:31
@ghost ghost locked as resolved and limited conversation to collaborators Jun 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sbomer sbomer sbomer approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar marek-safar is a code owner

Assignees

@vitek-karas vitek-karas

Labels
area-Tools-ILLink .NET linker development as well as trimming analyzers linkable-framework Issues associated with delivering a linker friendly framework test-enhancement Improvements of test source code
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@vitek-karas @sbomer