-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Enable PackedSimd in the interpreter; interpreter/jiterpreter v128 bug fixes #86136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kg
commented
May 12, 2023
- Fix trimming only honoring WasmEnableSIMD if AOT was also enabled
- Turn MINT_NIY back into a real opcode that asserts so we can use it as a replacement for unimplemented PackedSimd methods
- Fix incorrect ordering in sri_vector128_t_methods
- Fix missing names in sri_packedsimd_methods
- When transforming a call to a PackedSimd method, always either produce a real implementation or a MINT_NIY so that it will fail in a sensible way instead of overflowing the stack
- Implement V128_Ix_EXTRACT_MSB in the jiterpreter
- New hopefully not broken V128_Ix_CREATE_SCALAR implementation in the jiterpreter
Fix trimming removing SIMD even if SIMD was enabled
When transforming a PackedSimd call with PackedSimd disabled, generate a MINT_NIY that will assert
Tagging subscribers to 'arch-wasm': @lewing Issue Details
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.