Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser] introduce sourcemaps #86152

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented May 12, 2023

For dotnet.runtime.js and dotnet.js, which are built from our typescript.

  • It will link file:///C:/Dev/runtime/src/mono/wasm/runtime/loader/logging.ts while running on local machine.
    • This doesn't work on FF, but it does on Chrome.
  • It will link https://raw.githubusercontent.com/dotnet/runtime/a146e4e3a58e7287fe831164b3ee273b83c52758/src/mono/wasm/runtime/loader/logging.ts when built on CI, with the correct git hash.
  • public MSBuild property WasmEmitSourceMap, defaults to true for build and false for publish

@ghost
Copy link

ghost commented May 12, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

For dotnet.runtime.js and dotnet.js, which are built from our typescript.

  • It will link file:///C:/Dev/runtime/src/mono/wasm/runtime/loader/logging.ts while running on local machine.
    • This doesn't work on FF, but it does on Chrome.
  • It will link https://raw.githubusercontent.com/dotnet/runtime/a146e4e3a58e7287fe831164b3ee273b83c52758/gging.ts when built on CI, with the correct git hash.
Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript

Milestone: 8.0.0

Copy link
Member

@maraf maraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should have build time configuration for propagation to the build output folder (I believe off by default, or at least for publish)

@ghost ghost added needs-author-action An issue or pull request that requires more info or actions from the author. and removed needs-author-action An issue or pull request that requires more info or actions from the author. labels May 18, 2023
@pavelsavara pavelsavara requested a review from maraf June 28, 2023 09:38
@pavelsavara
Copy link
Member Author

It should have build time configuration for propagation to the build output folder (I believe off by default, or at least for publish)

Done via WasmEmitSourceMap

Copy link
Member

@maraf maraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@pavelsavara pavelsavara merged commit cf50b7d into dotnet:main Jun 28, 2023
171 of 174 checks passed
@ghost ghost locked as resolved and limited conversation to collaborators Jul 28, 2023
@pavelsavara pavelsavara deleted the browser_source_map branch September 2, 2024 15:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants