Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EventPipe shutdown logic #86180

Merged
merged 1 commit into from
May 15, 2023
Merged

Conversation

davmason
Copy link
Member

A typo from #78852 means we weren't waiting for threads to finish writing events before shutting down the session.

Fixes #85261
Fixes #86134
Fixes #85213
Fixes #84813

Update ep-thread.c
@davmason davmason added this to the 8.0.0 milestone May 12, 2023
@davmason davmason requested review from lateralusX and a team May 12, 2023 20:57
@davmason davmason self-assigned this May 12, 2023
Copy link
Member

@lateralusX lateralusX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@lateralusX
Copy link
Member

This will most likely fix #84257 as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.