Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: Fix new helper calls for some block copies involving promoted locals #86246

Merged
merged 5 commits into from
May 15, 2023
Merged

JIT: Fix new helper calls for some block copies involving promoted locals #86246

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1b84464
JIT: Fix new helper calls for some block copies involving promoted lo…
jakobbotsch May 15, 2023
9861135
Revert "JIT: Fix new helper calls for some block copies involving pro…
jakobbotsch May 15, 2023
2ed28c2
Avoid helper for TYP_BYREF GC pointers
jakobbotsch May 15, 2023
33ed42d
Revert "Avoid helper for TYP_BYREF GC pointers"
jakobbotsch May 15, 2023
479ef79
Revert "Revert "JIT: Fix new helper calls for some block copies invol…
jakobbotsch May 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/coreclr/jit/morphblock.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -830,10 +830,13 @@ void MorphCopyBlockHelper::MorphStructCases()
// A simple heuristic when field by field copy is preferred:
// - if fields can be enregistered;
// - if the struct has only one field.
// - if the copy involves GC pointers and the destination isn't stack (backend uses a helper for these block
// copies)
bool dstFldIsProfitable =
((m_dstVarDsc != nullptr) && (!m_dstVarDsc->lvDoNotEnregister || (m_dstVarDsc->lvFieldCnt == 1)));
bool srcFldIsProfitable =
((m_srcVarDsc != nullptr) && (!m_srcVarDsc->lvDoNotEnregister || (m_srcVarDsc->lvFieldCnt == 1)));
bool srcFldIsProfitable = ((m_srcVarDsc != nullptr) && (!m_srcVarDsc->lvDoNotEnregister ||
(m_srcVarDsc->HasGCPtr() && (m_dstVarDsc == nullptr)) ||
(m_srcVarDsc->lvFieldCnt == 1)));
// Are both dest and src promoted structs?
if (m_dstDoFldAsg && m_srcDoFldAsg && (dstFldIsProfitable || srcFldIsProfitable))
{
Expand Down