-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ubuntu 23.10 (Mantic Minotaur) RIDs to .NET 6 #86309
Add Ubuntu 23.10 (Mantic Minotaur) RIDs to .NET 6 #86309
Conversation
* library Microsoft.NETCore.Platforms - added RIDs to runtime.compatibility.json - added RIDs to runtime.json - added Mantic Version Id to Ubuntu runtimeGroups.props - incremented ServicingVersion in Microsoft.NETCore.Platforms.csproj
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue Detailsmain PR #85912 DescriptionAdds the Ubuntu 23.10 (Mantic Minotaur) RIDs to .NET 7
Customer ImpactWill be able to target their build specifically for Ubuntu 23.10 (Mantic Minotaur) or include Ubuntu 23.10 (Mantic Minotaur) platform-specific assets. RegressionNo. Testing
As far as I can tell the change works as expected. Note: Builds & local Tests pass in RiskAs for every change an unintended regression could be introduced. The risk for this is minimal, as the PR into main (#84983) and a recent similar PR for Ubuntu 22.10 (Kinetic Kudu) for.NET 7 (#84984) and .NET 6 (#85912) passed Package authoring signed off?Adding the Ubuntu 23.10 (Mantic Minotaur) RIDs was also suggested by @wfurt (see: #84984 (comment))
|
Any idea about the failure @carlossanlop? It seems like we should not need to update |
@wfurt The all-configurations failure is expected right now because I already merged the PR that resets the OOB packages from last month, and we haven't pushed those packages to nuget yet (it's done on GA). Is this needed for the June release or can it wait for next month? Code Complete was yesterday. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need this for the June release, but the version number needs to stay 10.
@@ -19,7 +19,7 @@ | |||
|
|||
<!-- When building from source, ensure the RID we're building for is part of the RID graph --> | |||
<AdditionalRuntimeIdentifiers Condition="'$(DotNetBuildFromSource)' == 'true'">$(AdditionalRuntimeIdentifiers);$(OutputRID)</AdditionalRuntimeIdentifiers> | |||
<ServicingVersion>10</ServicingVersion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to continue being 10. We only bump the number once per release.
src/libraries/Microsoft.NETCore.Platforms/src/Microsoft.NETCore.Platforms.csproj
Outdated
Show resolved
Hide resolved
…e.Platforms.csproj
main PR #85912
Description
Adds the Ubuntu 23.10 (Mantic Minotaur) RIDs to .NET 6
runtime.compatibility.json
runtime.json
runtimeGroups.props
ServicingVersion
inMicrosoft.NETCore.Platforms.csproj
Customer Impact
Will be able to target their build specifically for Ubuntu 23.10 (Mantic Minotaur) or include Ubuntu 23.10 (Mantic Minotaur) platform-specific assets.
Regression
No.
Testing
build.sh libs -allconfigurations
artifacts/bin/packages/Debug
for the existence ofMicrosoft.NETCore.Platforms
, with the appropriate package version.test -d artifacts/bin/Microsoft.NETCore.Platforms/ && echo "Ok"
test -e artifacts/bin/Microsoft.NETCore.Platforms/net6.0-Debug/Microsoft.NETCore.Platforms.BuildTasks.dll && echo "Ok"
grep ubuntu.23.10 artifacts/bin/Microsoft.NETCore.Platforms/Debug/runtime.json.dgml
showsMicrosoft.NETCore.Platforms
Library functions are callableAs far as I can tell the change works as expected.
Note: Builds & local Tests pass in
ppa:dviererbe/dotnet6-0-116-mantic-2
(link) with this patch applied.Risk
As for every change an unintended regression could be introduced. The risk for this is minimal, as the PR into main (#84983) and a recent similar PR for Ubuntu 22.10 (Kinetic Kudu) for.NET 7 (#84984) and .NET 6 (#85912) passed
Package authoring signed off?
Adding the Ubuntu 23.10 (Mantic Minotaur) RIDs was also suggested by @wfurt (see: #84984 (comment))