Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ComInterfaceGenerator] Warn if StringMarshalling doesn't match base and warn if base interface cannot be generated #86467

Merged
merged 17 commits into from
May 24, 2023

Conversation

jtschuster
Copy link
Member

@jtschuster jtschuster commented May 18, 2023

Warns if the base interface does not have the same StringMarshalling or if a base interface cannot be generated. Adds a LocationInfo to be able to produce diagnostics for interfaces without the ISymbol or anything that ruins incrementality.

This defines a few diagnostics / behaviors:

  • If a base interface fails to be generated, then the inheriting interfaces will not be generated.
  • If a base interface defines StringMarshalling, then all inheriting interfaces must match the base StringMarshalling.
  • If a base interface does not define StringMarshalling (because it doesn't use strings or uses MarshaAs / MarshalUsing for each), an inheriting interface may define StringMarshalling with no error.

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost assigned jtschuster May 18, 2023
@ghost
Copy link

ghost commented May 18, 2023

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

Warns if the base interface does not have the same StringMarshalling or if a base interface cannot be generated. Adds a LocationInfo to be able to produce diagnostics for interfaces without the ISymbol or anything that ruins incrementality.

Still a few TODOs to clean it up, but the main logic likely won't change if you want to take a look.

Author: jtschuster
Assignees: jtschuster
Labels:

area-System.Runtime.InteropServices, new-api-needs-documentation

Milestone: -

@jtschuster jtschuster merged commit 94c989d into dotnet:main May 24, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants