-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ComInterfaceGenerator] Warn if StringMarshalling doesn't match base and warn if base interface cannot be generated #86467
[ComInterfaceGenerator] Warn if StringMarshalling doesn't match base and warn if base interface cannot be generated #86467
Conversation
…ratorStringMarshalling
…conditional access
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsWarns if the base interface does not have the same StringMarshalling or if a base interface cannot be generated. Adds a LocationInfo to be able to produce diagnostics for interfaces without the ISymbol or anything that ruins incrementality. Still a few TODOs to clean it up, but the main logic likely won't change if you want to take a look.
|
Warns if the base interface does not have the same StringMarshalling or if a base interface cannot be generated. Adds a LocationInfo to be able to produce diagnostics for interfaces without the ISymbol or anything that ruins incrementality.
This defines a few diagnostics / behaviors: