-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix marking of saved assemblies #86474
Conversation
Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas Issue DetailsFixes #86242. This ensures the fix from #82197 works also for assemblies which get the It also ensures that
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if there are other use cases of Save
... this is a rather big change for those. @radekdoulik could you please check size of Xamarin Android once this change propagates all the way there?
Also - do you know who's tracking iOS size?
...o.Linker.Tests.Cases/Inheritance.Interfaces/StaticInterfaceMethods/OverrideInSaveAssembly.cs
Outdated
Show resolved
Hide resolved
…rfaces/StaticInterfaceMethods/OverrideInSaveAssembly.cs Co-authored-by: Jackson Schuster <36744439+jtschuster@users.noreply.github.com>
Yes, unfortunately I don't have a great way to evaluate this. I checked link times of the repro and didn't see any significant difference with the fix. |
We should not see any impact in runtime or asp.net, as those should all use full trimming everywhere. This should only impact Xamarin and maybe Blazor scenarios. |
Fixes #86242.
This ensures the fix from #82197 works also for assemblies which get the
save
action (which isn't supported from the command-line, but may happen in custom steps).It also ensures that
save
assemblies get fully marked regardless ofDisableMarkingOfCopyAssemblies
.