[mono][jit] Add JIT support for the methods in Vector128<T> on amd64. #86546
Conversation
ghost
assigned 
vargaz
changed the title
vargaz
force-pushed
the
amd64-vector-t
branch
4 times, most recently
from
7848094
to
d445a8e
Compare
vargaz
force-pushed
the
amd64-vector-t
branch
3 times, most recently
from
c517378
to
380593e
Compare
…d, and they keep their inputs alive.
vargaz
changed the title
|
There are still some test failures on the llvmaot lane. |
| switch (ins->inst_c1) { | ||
| case MONO_TYPE_I1: | ||
| case MONO_TYPE_U1: | ||
| amd64_sse_pxor_reg_reg (code, SIMD_TEMP_REG, SIMD_TEMP_REG); |
There was a problem hiding this comment.
This could be simplified to:
pxor dreg, dreg
psubb dreg, sreg1
|
Failures look unrelated. Some of the code generated for some methods might not be optimal, but that probably doesn't matter at this point due to other simd codegen shortcomings. |
| if (vector_size != 128) | ||
| return NULL; | ||
| #ifdef TARGET_WIN32 | ||
| return NULL; |
There was a problem hiding this comment.
@vargaz if I understand this correctly, there is currently no support for Vector128<T> on windows-x64, is that correct?
I am asking this because I noticed System.Runtime.Intrinsics.Tests.Vectors.Vector128Tests.* started failing on runtime-extra-platforms pipeline in the following legs:
- net8.0-windows-Release-x64-Mono_Release-Windows.11.Amd64.Client.Open
- net8.0-windows-Release-x64-Mono_Release-Windows.Amd64.Server2022.Open
- net8.0-windows-Release-x64-Mono_Release-Windows.81.Amd64.Open
which was reported here: #88983
The failures started happening on Jun-14 being the same date when this PR got merged in.
Should we disable the tests? And is there a tracking issue about the missing support?
There was a problem hiding this comment.
Yes, there is no support right now. In theory, this PR shouldn't have changed anything on winx64, since the support was disabled previously as well.
There was a problem hiding this comment.
I agree. I was puzzled by this as well.
There was a problem hiding this comment.
Thanks, I will continue investigating.
Contributes to #86272