Use u8 literals in ManagedTextSection.
#86657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-reflection-metadata Issue DetailsInstead of iterating the characters of a string, casting them into bytes and writing them, we use
|
This was referenced May 23, 2023
danmoseley
approved these changes
May 24, 2023
| @@ -788,7 +788,7 @@ public void WriteBytes(byte[] buffer, int start, int byteCount) | |||
| WriteBytes(buffer.AsSpan(start, byteCount)); | |||
| } | |||
|
|
|||
| private void WriteBytes(ReadOnlySpan<byte> buffer) | |||
| internal void WriteBytes(ReadOnlySpan<byte> buffer) | |||
There was a problem hiding this comment.
I prefer to not move it to minimize changes. It will become public with #85280 either way.
|
The failures unrelated and known |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of iterating the characters of a string, casting them into bytes and writing them, we use
u8literals and directly write the UTF-8 span of them.