Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QUIC ALPN list narrowing down scenario test #86659

Merged
merged 9 commits into from
Jun 22, 2023
Merged

QUIC ALPN list narrowing down scenario test #86659

merged 9 commits into from
Jun 22, 2023

Conversation

liveans
Copy link
Member

@liveans liveans commented May 23, 2023

Fixes #49423

@ghost ghost assigned liveans May 23, 2023
@liveans liveans requested a review from wfurt May 23, 2023 19:55
@ghost
Copy link

ghost commented May 23, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #49423

Author: liveans
Assignees: -
Labels:

area-System.Net.Quic
Milestone: -

@liveans liveans requested a review from ManickaP May 23, 2023 19:55
@liveans @CarnaViire
Update src/libraries/System.Net.Quic/tests/FunctionalTests/QuicListen…
9ca6e7c 
…erTests.cs

Co-authored-by: Natalia Kondratyeva <knatalia@microsoft.com>
@build-analysis build-analysis bot mentioned this pull request May 24, 2023
Closed
@build-analysis build-analysis bot mentioned this pull request May 24, 2023
Closed
rzikm
rzikm approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@rzikm rzikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo existing comments

ManickaP
ManickaP approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo comments, thanks!

src/libraries/System.Net.Quic/tests/FunctionalTests/QuicListenerTests.cs Outdated Show resolved Hide resolved
src/libraries/System.Net.Quic/tests/FunctionalTests/QuicListenerTests.cs Outdated Show resolved Hide resolved
src/libraries/System.Net.Quic/tests/FunctionalTests/QuicListenerTests.cs Outdated Show resolved Hide resolved
@build-analysis build-analysis bot mentioned this pull request May 25, 2023
Open
@liveans liveans mentioned this pull request Jun 2, 2023
Merged
@liveans liveans mentioned this pull request Jun 12, 2023
Closed
@liveans liveans merged commit 5bc65b0 into dotnet:main Jun 22, 2023
@karelz karelz added this to the 8.0.0 milestone Jul 3, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@CarnaViire CarnaViire CarnaViire left review comments

@rzikm rzikm rzikm approved these changes

@ManickaP ManickaP ManickaP approved these changes

@wfurt wfurt Awaiting requested review from wfurt

Assignees

@liveans liveans

Labels
area-System.Net.Quic
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

QUIC: Validate SslServerAuthenticationOptions set on QuicListenerOptions
6 participants
@liveans @CarnaViire @ManickaP @wfurt @rzikm @karelz