Fix StringMarshalling error message and actually copy attributes from methods to shadows #86731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… methods to shadows
jkoritzinsky
approved these changes
May 24, 2023
...s/System.Runtime.InteropServices/gen/LibraryImportGenerator/LibraryImportGeneratorHelpers.cs
Outdated
Show resolved
Hide resolved
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsJust a couple small changes to make the diagnostics represent the actual attribute in question, and fix a bug that attributes weren't actually being carried over to the shadowing methods.
|
AaronRobinsonMSFT
approved these changes
May 24, 2023
…Generator/LibraryImportGeneratorHelpers.cs Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>
This was referenced May 26, 2023
jtschuster
added a commit
that referenced
this pull request
May 30, 2023
…r attributes The issue dotnet/source-build#3483 looks similar to the issues I found before fixing in #86731. The relevant changes were in ComMethodContext.cs. If it's the same issue I was hitting, the attribute syntax was being copied over without adding 'using' statements or changing the attribute name to be fully qualified. I haven't validated yet, but this should fix it by just not copying the attributes for the parameters since they're not strictly necessary.
carlossanlop
pushed a commit
that referenced
this pull request
May 30, 2023
…and don't copy parameter attributes (#86899) * Use fully qualified type names for parameters and don't copy parameter attributes The issue dotnet/source-build#3483 looks similar to the issues I found before fixing in #86731. The relevant changes were in ComMethodContext.cs. If it's the same issue I was hitting, the attribute syntax was being copied over without adding 'using' statements or changing the attribute name to be fully qualified. I haven't validated yet, but this should fix it by just not copying the attributes for the parameters since they're not strictly necessary. * Add test for change
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a couple small changes to make the diagnostics represent the actual attribute in question, and fix a bug that attributes weren't actually being carried over to the shadowing methods.