-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some more testing around shadowing, inheritance, and project boundaries. #86732
Conversation
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsInitially this was meant to be a test suite to catch #86662, but now it's just regression tests for it and behavior validation tests for other scenarios I thought of at the time.
|
...e.InteropServices/tests/ComInterfaceGenerator.Unit.Tests/ComInterfaceGeneratorOutputShape.cs
Outdated
Show resolved
Hide resolved
test.SolutionTransforms.Add((sln, _) => | ||
{ | ||
var additionalProject = sln.Projects.First(proj => proj.Name == "Other"); | ||
return additionalProject.WithCompilationOptions(new CSharpCompilationOptions(OutputKind.DynamicallyLinkedLibrary, allowUnsafe: true)).Solution; | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it's worth it to make a new Test subclass for tests with AdditionProjects?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I think doing it manually for the cases where we need it is okay. It's not a lot of packages and it's easy to mess with.
Also I'll probably fix this issue in the Roslyn-SDK at some point and then we can get rid of the solution transform.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Failures are all known. |
Initially this was meant to be a test suite to catch #86662, but now it's just regression tests for it and behavior validation tests for other scenarios I thought of at the time.