-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm][build] Don't use GetTempFileName; emit webcil to subdir of obj #86972
[wasm][build] Don't use GetTempFileName; emit webcil to subdir of obj #86972
Conversation
See dotnet#73793 Instead of using GetTempFileName (which can run out of temp file names on Windows after 64K files), emit the temporary webcil files to a directory in IntermediateOutputPath before copying them to the final location, if they changed (which is elsewhere in IntermediateOutputPath).
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsInstead of using GetTempFileName (which can run out of temp file names on Windows after 64K files, see #73793), emit the temporary webcil files to a directory in IntermediateOutputPath before copying them to the final location, if they changed (which is elsewhere in IntermediateOutputPath).
|
/cc @javiercn |
The above issue was fixed. It can't run out any more. |
This runs in application publish and msbuild tasks use framework when run from VS. It worked fine from the cli |
wbt failures are known. not sure why they aren't getting tagged by build analysis |
Instead of using GetTempFileName (which can run out of temp file names on Windows after 64K files, see #73793), emit the temporary webcil files to a directory in IntermediateOutputPath before copying them to the final location, if they changed (which is elsewhere in IntermediateOutputPath).
An example of the failure with the old implementation: