Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Random for ulong #87219

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Simplify Random for ulong #87219

merged 1 commit into from
Jun 8, 2023

Conversation

MichalPetryka
Copy link
Contributor

Use Math.BigMul instead of UInt128 since both values are always ulongs.

@MichalPetryka
Simplify Random for ulong
5f385e2 
Use Math.BigMul instead of UInt128 since both values are always ulongs.
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 7, 2023
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jun 7, 2023
tannergooding
tannergooding approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@tannergooding tannergooding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is doing obviously less work and explicitly gives us the two separate parts we end up dealing with anyways.

@vcsjones vcsjones added area-System.Runtime and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jun 7, 2023
@ghost
Copy link

ghost commented Jun 7, 2023

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

Issue Details

Use Math.BigMul instead of UInt128 since both values are always ulongs.

Author: MichalPetryka
Assignees: -
Labels:

area-System.Runtime, community-contribution
Milestone: -

@build-analysis build-analysis bot mentioned this pull request Jun 7, 2023
Closed
@stephentoub stephentoub merged commit 5353824 into dotnet:main Jun 8, 2023
@build-analysis build-analysis bot mentioned this pull request Jun 8, 2023
Closed
@kotlarmilos kotlarmilos mentioned this pull request Jun 14, 2023
Closed
This was referenced Jun 15, 2023
Closed
Closed
@kotlarmilos kotlarmilos mentioned this pull request Jun 29, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Jul 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@tannergooding tannergooding tannergooding approved these changes

Assignees
No one assigned
Labels
area-System.Runtime community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MichalPetryka @stephentoub @tannergooding @vcsjones