[release/6.0-staging] Fix neutral cultures created with the underscore #87415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/area-system-globalization Issue DetailsBackport of #87411 to release/6.0-staging /cc @tarekgh Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
eiriktsarpalis
approved these changes
Jun 12, 2023
This was referenced Jun 12, 2023
|
@tarekgh @eiriktsarpalis Today is code complete for the July release. If you want this change to be included in that release, please get a tactics approval, a sign-off, confirm the CI failures are unrelated, and merge it before EOD today. |
tarekgh
added
Servicing-approved
|
approved offline by email. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #87411 to release/6.0-staging
/cc @tarekgh
Customer Impact
This is a delta change to the original fix we did in #87177
Testing
Ran regression tests and added more test cases.
Risk
Low as we are not changing any logic other than ensuring compatibility.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.