Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Options validation source generator #87587

Merged
merged 13 commits into from
Jun 20, 2023
Merged

Options validation source generator #87587

merged 13 commits into from
Jun 20, 2023

Commits on Jun 14, 2023

  1. Options validation source generator

    @tarekgh
    tarekgh committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    304dd3d View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. Add source gen to the package and clean up some resources

    @tarekgh
    tarekgh committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    b662e52 View commit details
    Browse the repository at this point in the history

  2. Change the initialization to use ForAttributeWithMetadataName

    @tarekgh
    tarekgh committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    f20f8e6 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. Excluding tests on WASM

    @tarekgh
    tarekgh committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    86409c0 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2023

  1. Address Martin's feedback

    @tarekgh
    tarekgh committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    9456bf5 View commit details
    Browse the repository at this point in the history

  2. Address Jeff's comments

    @tarekgh
    tarekgh committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    f61cae6 View commit details
    Browse the repository at this point in the history

  3. Replace the calls of ValidationAttribute.GetValidationResult with Val… 

    …idator.TryValidateValue

Instead of validating each attribute separately, instead we collect the list of the attributes we need to validate and then call Validator.TryValidateValue. This will guarantee performing the same validation order as the runtime.
    @tarekgh
    tarekgh committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    8e6c7a0 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2023

  1. Avoid calling List.Clean and create the list with initial capacity

    @tarekgh
    tarekgh committed Jun 18, 2023
    Configuration menu
    Copy the full SHA
    c18789c View commit details
    Browse the repository at this point in the history

  2. Pass down the SematicModel from the generator to the parser

    @tarekgh
    tarekgh committed Jun 18, 2023
    Configuration menu
    Copy the full SHA
    8ea301d View commit details
    Browse the repository at this point in the history

  3. Add isolated unit test

    @tarekgh
    tarekgh committed Jun 18, 2023
    Configuration menu
    Copy the full SHA
    54a2f97 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. Final fixes

    @tarekgh
    tarekgh committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    9119332 View commit details
    Browse the repository at this point in the history

  2. Fix resource messages

    @tarekgh
    tarekgh committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    c98e5fc View commit details
    Browse the repository at this point in the history

  3. Address more feedback

    @tarekgh
    tarekgh committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    ec2c6e4 View commit details
    Browse the repository at this point in the history