Fix a number of source generator bugs. #87796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsThis PR:
|
eiriktsarpalis
force-pushed
the
add-sourcegen-diagnostics
branch
from
dd867e9 to
7029e02
Compare
eiriktsarpalis
commented
Jun 20, 2023
| // Compile the referenced assembly first. | ||
| Compilation campaignCompilation = CompilationHelper.CreateCampaignSummaryViewModelCompilation(); | ||
| Compilation eventCompilation = CompilationHelper.CreateActiveOrUpcomingEventCompilation(); | ||
| // Compile the referenced assembly first. |
There was a problem hiding this comment.
These diffs fix a couple of tests that were actually failing to compile but we weren't checking for that. Discovered by the newly added diagnostics.
layomia
reviewed
Jun 20, 2023
...on/tests/System.Text.Json.SourceGeneration.Unit.Tests/JsonSourceGeneratorDiagnosticsTests.cs
Show resolved
Hide resolved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
JsonSerializerContextattribute parsing implementation from reading from syntax trees to reading from symbols. Fixes System.Text.Json using interpolated string with JsonSerializable.TypeInfoPropertyName fails with ArgumentException #69207. Fixes SourceGen build errors if JsonSerializableAttribute argument name 'type' is included #82997.JsonConverterAttributeannotations contain invalid or inaccessible converter types. Fixes Emit a diagnostic when encountering JsonConverterAttribute annotations with inaccessible converter type constructors. #87140.